optimize: optimize synchronization procedure #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 29, 2024 19:49
…f goroutine) and reconstruct project layout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to optimize current operator synchronization procedure. Currently, we use goroutine to poll and call
changeClusterAPI. However, it is prone to lead to unexpected race condition.As illustrated in the above figure, the former
changeClustermay override the latter. This PR instead utilizes CR status and requeuing reconciliation. Besides, this PR also optimize project structure, moving core functionality to "pkg" folder and bumping go version to 1.21 (keep aligned with Dockerfile).